Add auto-instrumentation for compose navigation #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
reviewed
Oct 25, 2022
...ld/src/main/kotlin/io/sentry/android/gradle/instrumentation/SpanAddingClassVisitorFactory.kt
Outdated
Show resolved
Hide resolved
.compose.NavHostControllerKt contains an extension function for .NavHostController class
Merged
1 task
romtsn
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Overall looks good, great job 👍 Left some comments
Also, some tests are failing, probably needs adaptation after changing to a single ChainedInstrumentable.
Plus, we should also test auto-install stuff (unit + integration), you can check https://github.com/getsentry/sentry-android-gradle-plugin/blob/main/plugin-build/src/test/kotlin/io/sentry/android/gradle/SentryPluginAutoInstallTest.kt for the integration part
plugin-build/src/main/kotlin/io/sentry/android/gradle/util/Versions.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/io/sentry/android/gradle/instrumentation/androidx/compose/ComposeNavigation.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Nov 3, 2022
romtsn
reviewed
Nov 3, 2022
romtsn
reviewed
Nov 3, 2022
plugin-build/src/main/kotlin/io/sentry/android/gradle/util/Versions.kt
Outdated
Show resolved
Hide resolved
Replace testRuntimeOnly with testImplementationAar as otherwise the Gradle sync fails with the following error: - Incompatible because this component declares an API of a component, with the library elements 'aar' and the consumer needed a runtime of a component, packaged as a jar
E.g. the compose integration requires both a specific androidx runtime version as well as sentry SDK version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Modifies the androidx
rememberNavControllermethod to automatically report navigation events to sentry.💡 Motivation and Context
Related issue: getsentry/sentry-java#2319
Requires getsentry/sentry-java#2320 to be merged and released first.
💚 How did you test it?
For now just manually.
📝 Checklist
🔮 Next steps